Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KNOX-3072: Fix for GatewayBasicFuncTest.testEncodedForwardSlash fail #948

Merged
merged 1 commit into from
Nov 5, 2024
Merged

KNOX-3072: Fix for GatewayBasicFuncTest.testEncodedForwardSlash fail #948

merged 1 commit into from
Nov 5, 2024

Conversation

hanicz
Copy link
Contributor

@hanicz hanicz commented Oct 31, 2024

What changes were proposed in this pull request?

Shiro was upgraded from 1.10.0 to 1.13.0 in a previous PR. Due to this the GatewayBasicFuncTest.testEncodedForwardSlash is failing. This fix is addressing that.

How was this patch tested?

Unit tests

pzampino
pzampino approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@pzampino pzampino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

smolnar82
smolnar82 reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@smolnar82 smolnar82 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanicz - you may also consider setting the blockSemicolon and blockNonAscii properties to false to match what we have in our ShiroConfig. See #378 and #610 for further information.

@pzampino
Copy link
Contributor

@hanicz - you may also consider setting the blockSemicolon and blockNonAscii properties to false to match what we have in our ShiroConfig. See #378 and #610 for further information.

I prefer this suggestion. Can you apply it to this PR?

@pzampino
Copy link
Contributor

pzampino commented Nov 1, 2024

@hanicz - you may also consider setting the blockSemicolon and blockNonAscii properties to false to match what we have in our ShiroConfig. See #378 and #610 for further information.

I prefer this suggestion. Can you apply it to this PR?

What I meant is that I think we should fix this in the ShiroConfig class, rather than just the test code. We probably should not introduce the additional config properties as part of this PR though.

@hanicz
Copy link
Contributor Author

hanicz commented Nov 4, 2024

@smolnar82 @pzampino
I added the blockEncodedForwardSlash to the ShiroConfig class

moresandeep
moresandeep approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@moresandeep moresandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@smolnar82
Copy link
Contributor

@smolnar82 @pzampino I added the blockEncodedForwardSlash to the ShiroConfig class

Thanks, @hanicz ! LGTM!

@smolnar82 smolnar82 merged commit dceb495 into apache:master Nov 5, 2024
2 checks passed
@smolnar82 smolnar82 mentioned this pull request Nov 5, 2024
Merged
lmccay pushed a commit to lmccay/knox that referenced this pull request Nov 9, 2024
@hanicz @lmccay
KNOX-3072: Added blockEncodedForwardSlash to ShiroConfig (apache#948)
df84812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smolnar82 smolnar82 smolnar82 approved these changes

@pzampino pzampino pzampino approved these changes

@lmccay lmccay lmccay approved these changes

@moresandeep moresandeep moresandeep approved these changes

Assignees

@hanicz hanicz

Labels
Shiro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanicz @pzampino @smolnar82 @moresandeep @lmccay